-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report duration of each iteration #38
base: main
Are you sure you want to change the base?
Conversation
Just listing out all the timings for each iteration is going to get way too large to work with. How about using histogram bucketing and reporting that instead? that way you get the median and percentiles reported in a single short list of numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. nope sorry.. I 'd like just the fix.. and then we need to work on the durations output being optional and not forced in by default
@madninja |
"iterations": self.iterations, | ||
"avg_ms": round2(avg_ms), | ||
"rate": round2(rate), | ||
}); | ||
if self.durations { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not map durations to a Vec of mills and then just insert it into the top level json?
e.g.
let durations: Vec<u128> = durations.map(|d| d.as_millis()).collect();
and in the json construction above:
let json = json!({
"iterations": self.iterations,
"avg_ms": round2(avg_ms),
"rate": round2(rate),
"durations": durations,
});
Madninja/ecc config
update from main
Joecryptotoo/wake fix
docker-compose.yml for testing:
Just run
docker compose up
and this should build from my bench branch and run.