Do not attempt to reconnect on every packet received #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a gateway is connected, attempt to send all waiting packets. Otherwise we store and move on, the reconnection logic will trigger sending the packets when it is successful. I changed the reconnect logging verbage to only be about the connection. It's a bit confusing to read the logs and immediately see that you're "reconnecting" when the gateway is connecting for the first time.
madninja
force-pushed
the
mj/router-reconnect
branch
2 times, most recently
from
c792aa9
to
52e2fa3
Compare
This change will recalculate the reconnect timer based on the fact that there was an error during the router. If an error happens during a fresh connection the reconnect timer will be set to a short time using `next_connect` which will not try to connect immediately. The subseequent timer firing will end up reconnecting the router and sending the messages
madninja
force-pushed
the
mj/router-reconnect
branch
from
52e2fa3
to
7bb6e09
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a gateway is connected, attempt to send all waiting packets. Otherwise we store and move on, the reconnection logic will trigger sending the packets when it is successful.
I changed the reconnect logging verbiage to only be about the connection. It's a bit confusing to read the logs and immediately see that you're "reconnecting" when the gateway is connecting for the first time.
We only attempt to reconnect on
Err(err).Ok(None)means the stream was closed explicitly by the server.