Add TPM raw handle support #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isergieienkov
force-pushed
the
feature/raw_handle
branch
3 times, most recently
from
cca8e40
to
31d64c0
Compare
isergieienkov
force-pushed
the
feature/raw_handle
branch
2 times, most recently
from
9d7b0b4
to
9de47c6
Compare
isergieienkov
force-pushed
the
feature/raw_handle
branch
from
9de47c6
to
010e927
Compare
| uri_error!("could not load tpm keypair on path {path}: {err:?}") | ||
| })?; | ||
| let keypair = match key_access { | ||
| "esys" => tpm::KeypairHandle::from_key_handle( |
There was a problem hiding this comment.
What led you to add this match if you're only matching on esys? Is there another key_access that isn't being handled?
There was a problem hiding this comment.
ah. there were 3 different options before I removed old FAPI
madninja
approved these changes
Oct 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.