Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust first beacon offset #474

Merged
merged 1 commit into from
Nov 22, 2023
Merged

adjust first beacon offset #474

merged 1 commit into from
Nov 22, 2023

Conversation

madninja
Copy link
Member

This adjusts the beaceon time to select a beacon time in the full first window, and moves it to the next window if in the past

This adjusts the beaceon time to select a beacon time in the full first window, and moves it to the next window if in the past
Copy link
Contributor

@mawdegroot mawdegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, breaking down the logic here (for posterity):

When no beacon time exists, pick a random beacon time in the current window and recursively call the fun again. Then

  1. the beacon time is in the future and that time will be maintained. This can lead to an irregular interval beacon if the hotspot already beaconed in the current window.
  2. the beacon time is in the past and a new beacon will be schedules in the next window. This will not lead to an irregular interval beacon but may lead to a missed beacon

In both cases the normal schedule will resume after this logic.

@madninja madninja merged commit 1d69023 into main Nov 22, 2023
11 checks passed
@madninja madninja deleted the madninja/first_beacon_time branch November 22, 2023 14:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants