Goto next diagnostic error?

[leeola]

Would Helix be interested in a "Goto next diag error" command? Similar to goto_next_diag, but instead it goes specifically to an error severity.

I whipped up an example. Curious if ya'll are interested or not. A couple nitpicks with the idea/linked-code i have, for discussion sake:

1. A specific error variant of this command feels... verbose and repetitive. A parameterized version of it which can be configured to go to a specific severity could support all variations of this idea. ie go to any diag, go to warning diags, go to error diags, etc. Though i'm not clear if Helix commands can be parameterized like that? Eg key = goto_next_diag(error) in config.toml.
2. The above code needs tests. Not sure how to test that in this repo yet.
3. The doc.diagnostics().last() (and first) fallback should also filter to the desired severity.

Appreciate any thoughts :)

[leeola]

Some minor improvements to the branch: https://github.com/leeola/helix/tree/22.03-diag-next-err

Perhaps i should just PR it. 🤷

[EpocSquadron]

I do highly recommend a PR, you're very likely to get some eyes on it and constructive feedback. I could easily see this being merged once the kinks are worked out.

[leeola]

I'll close this then and open a PR once i have some additional time (soon i hope) to respond to PR feedback. Thanks!