Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goto_next_diag_error/goto_prev_diag_error #3405

Open
AceofSpades5757 opened this issue Aug 13, 2022 · 6 comments
Open

Add goto_next_diag_error/goto_prev_diag_error #3405

AceofSpades5757 opened this issue Aug 13, 2022 · 6 comments
Labels
C-enhancement Category: Improvements

Comments

@AceofSpades5757
Copy link
Contributor

Describe your feature request

Wanted to continue the conversation on going to the next error. I found this extremely useful in another editor and I get really annoyed because I usually have a lot of diagnostic points while I'm working out an issue.

Original Issue

For reference: Pull Request for next diagnostic

@AceofSpades5757 AceofSpades5757 added the C-enhancement Category: Improvements label Aug 13, 2022
@EpocSquadron
Copy link
Contributor

This already exists for the current document with ]d and [d. There is also document and workspace diagnostic pickers as of #2013

@the-mikedavis
Copy link
Member

If I understand correctly, this is only about showing the next error diagnostic, right? ]d/[d will bring you to the next diagnostic which could be info/warn/error

@EpocSquadron
Copy link
Contributor

That makes a lot more sense now!

@AceofSpades5757
Copy link
Contributor Author

Yeah, the diagnostics are great and all, but I'm usually trying to get to the next error first, then I can worry about the diagnostic details.

@94bryanr
Copy link

94bryanr commented Sep 1, 2023

I would also like to see this. Using the diagnostic picker in a workspace with hundreds/thousands of warnings requires a lot of scrolling around to find the next error.

I think having the diagnostics sorted by severity with errors at the top would make a lot of sense, as finding the next error (arguably the most common task you will be doing when opening the picker) would only require one extra keypress. Then within the severity buckets we could continue to use the current filename sorting.

@cgahr
Copy link
Contributor

cgahr commented Nov 4, 2023

There is also #6331, trying to implement the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

5 participants