LSP: Resolve completion items when any info is missing #10873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-bug
|
I think we likely need to do something similar for detail and documentation. I think this is a case where null and empty list/empty string satsify the same condition in vscode/JavaScript so a lot of lsps usw them interchangibly |
Rust-analyzer for example sends `Some([])` for completion items and then sends the actual additional text edits in the completionItem/resolve response. To be defensive we also guard against language servers sending empty details and documentation.
the-mikedavis
force-pushed
the
lsp-resolve-with-empty-additional-text-edits
branch
from
fe3b99f
to
f71cee8
Compare
the-mikedavis
changed the title
RoloEdits
reviewed
Jun 5, 2024
| || item.item.detail.is_none() | ||
| || item.item.additional_text_edits.is_none(); | ||
| if !needs_resolve { | ||
| // We consider an item to be fully resolved if it has non-empty, none-`None` details, |
There was a problem hiding this comment.
is none- supposed to be non-? Or is this implying something else?
There was a problem hiding this comment.
Yep that's a typo, should be "non-None"
pascalkuthe
approved these changes
Jun 5, 2024
archseer
approved these changes
Jun 6, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
AOx0
pushed a commit
to AOx0/helix
that referenced
this pull request
Jun 15, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust-analyzer for example sends
Some([])for completion items and then sends the actual additional text edits in the completionItem/resolve response.Fixes #10787