Fix tutor typo favourite to favorite
#4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime/tutor
Outdated
Comment on lines
522
to
523
| --> I like to eat apples since my favorite fruit is apples. | ||
| --> I like to eat apples since my favourite fruit is apples. | ||
| I like to eat oranges since my favourite fruit is oranges. |
There was a problem hiding this comment.
actually I think the typo is the one with the u - there's another favorite down on L833
There was a problem hiding this comment.
https://www.grammarly.com/blog/favorite-favourite/
favorite is American English, it is favourite everywhere else.
There was a problem hiding this comment.
It seems like we use American English elsewhere in the tutor, but the other "favorite" is the only example I found of that. I don't have strong feelings either way between American vs. British
There was a problem hiding this comment.
so i assume i will fix it up to use the AE version.
kirawi
added
A-documentation
SoraTenshi
changed the title
favoritefavourite to favorite
the-mikedavis
approved these changes
Sep 28, 2022
|
Thanks! |
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the mismatch of the word
favouriteandfavoritein the tutor.So i fixed that to be synchronous now.