This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[Prometheus] Updated cAdvisor endpoint #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated cadvisor scape endpoint so that it is compatible with Kubernetes 1.7.3+ See more here prometheus/prometheus#3181 (comment)
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XS
|
@mattfarina Could I ask you for review of this PR? |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mcwienczek, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
NicolasT
added a commit
to scality/Zenko
that referenced
this pull request
Feb 21, 2018
This new version contains various fixes, of which helm/charts#3684 is the most interesting, fixing cAdvisor metrics collection. To view all changes, run ```shell git log --reverse 702fb47980ddaa87c86b6e702c0067a94c959214..ddce4afd8d943d65feaf7cb73e6d6f5bd2a124ef stable/prometheus ``` in a clone of the Kubernetes Charts repository. See: helm/charts#3684
NicolasT
added a commit
to scality/Zenko
that referenced
this pull request
Feb 21, 2018
This new version contains various fixes, of which helm/charts#3684 is the most interesting, fixing cAdvisor metrics collection. To view all changes, run ```shell git log --reverse 702fb47980ddaa87c86b6e702c0067a94c959214..ddce4afd8d943d65feaf7cb73e6d6f5bd2a124ef stable/prometheus ``` in a clone of the Kubernetes Charts repository. See: helm/charts#3684
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 22, 2018
Primarily to get cadvisor rules back to working again by bringing in helm/charts#3684
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 22, 2018
Primarily to get cadvisor rules back to working again by bringing in helm/charts#3684 Currently the labels for various container metadata is not captured properly, so we have data for all container usage but no idea what container is what!
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* Updated values.yaml cadvisor endpoint Updated cadvisor scape endpoint so that it is compatible with Kubernetes 1.7.3+ See more here prometheus/prometheus#3181 (comment) * Added extensive description about the problem with cadvisor * Bumped chart version * Removed trailing spaces * Update Chart.yaml
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Updated values.yaml cadvisor endpoint Updated cadvisor scape endpoint so that it is compatible with Kubernetes 1.7.3+ See more here prometheus/prometheus#3181 (comment) * Added extensive description about the problem with cadvisor * Bumped chart version * Removed trailing spaces * Update Chart.yaml Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated cadvisor scape endpoint so that it is compatible with Kubernetes 1.7.3+
Also added comment how to edit default values.yaml in order to be able to scrape cAdvisor metrics in older clusters
See more here prometheus/prometheus#3181 (comment)
This change is backwards incompatible.