Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Impossible to change timeframe window #680

Open
lukou31 opened this issue Sep 1, 2021 · 29 comments
Open

[BUG] Impossible to change timeframe window #680

lukou31 opened this issue Sep 1, 2021 · 29 comments
Labels
bug Something isn't working

Comments

@lukou31
Copy link

lukou31 commented Sep 1, 2021

Describe the bug
No effect when changing "Show results for the last" to a different value from 7. Working fine before the upgrade.

Context
Version : 1.12.0
Synology - DSM7

@lukou31 lukou31 added the bug Something isn't working label Sep 1, 2021
@brommeltje
Copy link

Same issue on debian 10

@makidoll
Copy link

makidoll commented Sep 2, 2021

Same here, just running latest Docker image on x86_64. Will probably revert until fixed.

@masterwishx
Copy link

masterwishx commented Sep 2, 2021

Same issue in docker on Unraid (linux/amd64)

@jaxjexjox
Copy link

Ok so it's not just me! Damnit. I've logged a duplicate of this. Sorry.

@jaxjexjox
Copy link

Dupe here, sorry.
#682

@jaxjexjox
Copy link

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :(

I only see 4 versions here?!
https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated

Do I just pull dev?

@makidoll
Copy link

makidoll commented Sep 5, 2021

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :(

I only see 4 versions here?!
https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated

Do I just pull dev?

The dev doesn't upload each individual version on Docker hub for some reason... But I looked through my docker images and used the image id of the previously downloaded version

@jaxjexjox
Copy link

I have pulled the 4 month old 'dev' release and it has fixed nothing, the image appears to be identical somehow.
I (thought) I had a rough idea on how to work with docker, alas, perhaps this is not the case.

Anyone got any idea, how I can get back to the old edition, I need to convince my ISP I have a line fault and I'd really like to be able to produce some nice graphs.

@jaxjexjox
Copy link

jaxjexjox commented Sep 5, 2021

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :(
I only see 4 versions here?!
https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated
Do I just pull dev?

The dev doesn't upload each individual version on Docker hub for some reason... But I looked through my docker images and used the image id of the previously downloaded version

I'm an idiot who cleans up disk space by purging and pruning old stuff! :(

EDIT Ok I apologise I've just re-read your post and it's clear, they're not available for me to snatch again (honestly, I didn't know this was even possible!)

Any tips how I can spin up an old one?

@makidoll
Copy link

makidoll commented Sep 5, 2021

I've uploaded a tar.gz of the image on my server here: https://files.cutelab.space/f/ebb317bf98074fe78340/
Once loaded, you can use it with image id: 25b86b3d603a

I don't know how to prove this is the official release... I just want to help out. The owner of this project should really push the version tag and then latest tag to Docker hub.

wget -O speedtest-tracker-1.10.4.tar.gz "https://files.cutelab.space/f/ebb317bf98074fe78340/?dl=1"
docker load -i speedtest-tracker-1.10.4.tar.gz

@makidoll
Copy link

makidoll commented Sep 5, 2021

You might have to backup your data in the webui settings first, then remove your data volume, start the container fresh and import your data back in. It will break if you try to downgrade.

@jaxjexjox
Copy link

I <3 linux, open source stuff, docker and you!

Magic, just wonderful.
Thanks for the docker load command, I sat here in my windows mindset wondering how to extract the tar, copy the files into a folder full of images to work with. You probably saved me hours.

Did indeed have to backup data, been a bit of a mess but I have graphs now to show my ISP my line is stuffed.
Thanks again.
MUST stop being in the habit of purging and pruning behind me so regularly.

@makidoll
Copy link

makidoll commented Sep 5, 2021

I'm really glad I could help! I prune things pretty often too and I'm not afraid of going cutting edge. But this project definitely needs a Docker overhaul. It's not done correctly. Not only do versions not get released, but the owner copies the root of the main branch into a separate branch in a weird way, compile on their machine and then build the image.

I might send in a pr so you can docker build and it will compile and put everything together like it should. Then you can make fresh builds of any version without understanding php or npm.

@jaxjexjox
Copy link

They probably don't know any better (I know I don't) so any help for the original developer is probably quite helpful.

The only reason I'm using this, is because this guy broke this one.
roest01/docker-speedtest-analyser#75

It need a fork or some such which updates a file.
roest01/docker-speedtest-analyser#82

@Sn00zEZA
Copy link

Also having this issue

@henrywhitaker3
Copy link
Owner

Building a fix for this now lads. Was an issue with the refresh happening before the state was change, if u update the number of days again it has the right value the second time

henrywhitaker3 added a commit that referenced this issue Sep 10, 2021
#680: Fix issue where the data would refresh before the react state had updated
@henrywhitaker3
Copy link
Owner

Right turns out there was another issue, but have pushed a new dev and dev-arm image - see if it sorts it for you and will merge to master

@db77x
Copy link

db77x commented Sep 10, 2021

dev build 12.1 working now for down/upload and ping. But not for successful/faild graph.
Testest with various days 30, 180, 360 etc.
Maybe you can fix it also @henrywhitaker3 ?

@burtaverde
Copy link

can confirm, same results as db77x. Also i might be wrong, but if i remember correctly, it used to show the timeline on all graphs and currently they're empty on the bottom

@masterwishx
Copy link

confirm (dev) working Download,Upload,Ping Graphs on Unraid (linux/amd64) but not the Failure graph

@masterwishx
Copy link

v 1.12.2 dev all graphs is working now in Unraid (linux/amd64)

@jaxjexjox
Copy link

I take it this one isn't published as official yet, right? (where can I check? Sorry for hassling!)

@jaxjexjox
Copy link

Can I just confirm, this is still broken, in both latest and dev docker builds, right? (It's still dead for me)

@tuckshoprn
Copy link

tuckshoprn commented Sep 18, 2021 via email

@jaxjexjox
Copy link

Ok that's a bit odd, perhaps I need to nuke my data directory. I also notice this one sure chews some disk space.

@jaxjexjox
Copy link

Yeah looks like I needed a fresh data directory, no biggie, I could do with a fresh folder anyhow. Thanks for hard work henry.

@tuckshoprn
Copy link

tuckshoprn commented Sep 18, 2021 via email

@jaxjexjox
Copy link

I mean look, disk space is cheap, I'll get over it, but I'll say the CSV file from other apps is in the kilobytes, I'm not sure why so much is on the disk but no big deal, at least this works! Unlike roests one.

@Sn00zEZA
Copy link

Sn00zEZA commented Oct 12, 2021

When will this bug fix merge with latest for docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants