Skip to content

Commit

Permalink
fix: add node 14 to unit tests in CI. (#2254)
Browse files Browse the repository at this point in the history 
Change all package.json engines.node versions
remove unneeded @types/node dependencies
  • Loading branch information
@ryandagg
ryandagg committed Mar 1, 2023
1 parent bde5924 commit 2257add
Show file tree
Hide file tree
Showing 20 changed files with 20 additions and 51 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [16.x]
node-version: [14.x, 16.x]
os: [ubuntu-latest, macos-latest, windows-latest]
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
]
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"private": true,
"scripts": {
Expand Down
3 changes: 1 addition & 2 deletions packages/apps/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4",
"@types/mocha": "^5",
"@types/node": "^10",
"@types/shell-escape": "^0.2.0",
"@types/supports-color": "^5.3.0",
"@types/urijs": "^1.19.4",
Expand All @@ -34,7 +33,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/auth/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"@types/chai": "^4.1.7",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
"eslint": "^6.7.2",
Expand All @@ -32,7 +31,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/autocomplete/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"@types/lodash.flatten": "^4.4.6",
"@types/mocha": "5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "10.12.24",
"@typescript-eslint/eslint-plugin": "4.18.0",
"@typescript-eslint/parser": "4.18.0",
"chai": "4.2.0",
Expand All @@ -35,7 +34,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/buildpacks/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"@types/lodash": "^4.14.123",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/node-fetch": "^2.1.6",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
Expand All @@ -39,7 +38,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/certs/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4.1.7",
"@types/mocha": "^5.2.6",
"@types/node": "^10.12.24",
"chai": "^4.2.0",
"eslint": "^6.7.2",
"eslint-config-oclif": "^3.1.0",
Expand All @@ -24,7 +23,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
2 changes: 1 addition & 1 deletion packages/ci-v5/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"std-mocks": "^1.0.1"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/ci/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"@types/inquirer": "7.3.0",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/phoenix": "^1.4.0",
"@types/uuid": "^8.3.0",
"@types/validator": "^10.9.0",
Expand All @@ -48,7 +47,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
5 changes: 2 additions & 3 deletions packages/cli/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"@types/lodash": "^4.14.123",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"@types/write-json-file": "^3.2.1",
"aws-sdk": "^2.421.0",
Expand All @@ -83,7 +82,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/oclif.manifest.json",
Expand Down Expand Up @@ -243,7 +242,7 @@
},
"update": {
"node": {
"version": "14.19.0"
"version": "16.19.0"
},
"s3": {
"xz": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/config/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"@types/lodash": "^4.14.123",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
"eslint": "^6.7.2",
Expand All @@ -37,7 +36,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/git/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"@types/chai": "^4.1.7",
"@types/fs-extra": "^5.0.5",
"@types/mocha": "^5.2.6",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
"eslint": "^6.7.2",
Expand All @@ -32,7 +31,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/local/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4",
"@types/mocha": "^5",
"@types/node": "^10",
"bats": "^1.1.0",
"chai": "^4",
"eslint": "^6.7.2",
Expand All @@ -29,7 +28,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/oauth/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4",
"@types/mocha": "^5",
"@types/node": "^10",
"chai": "^4",
"eslint": "^6.7.2",
"eslint-config-oclif": "^3.1.0",
Expand All @@ -33,7 +32,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/bin",
Expand Down
3 changes: 1 addition & 2 deletions packages/pipelines/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"@types/lodash.sortby": "^4.7.6",
"@types/mocha": "5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "10.12.24",
"@typescript-eslint/eslint-plugin": "4.18.0",
"@typescript-eslint/parser": "4.18.0",
"chai": "4.2.0",
Expand All @@ -42,7 +41,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/ps/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@types/lodash": "^4.14.123",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
"eslint": "^6.7.2",
Expand All @@ -33,7 +32,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/run/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4",
"@types/mocha": "^5",
"@types/node": "^10",
"@types/node-notifier": "^5.4.0",
"bats": "^1.1.0",
"chai": "^4",
Expand All @@ -34,7 +33,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
3 changes: 1 addition & 2 deletions packages/status/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@types/chai": "^4.1.7",
"@types/mocha": "^5.2.6",
"@types/nock": "^9.3.1",
"@types/node": "^10.12.24",
"@types/supports-color": "^5.3.0",
"chai": "^4.2.0",
"eslint": "^6.7.2",
Expand All @@ -41,7 +40,7 @@
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"oclif.manifest.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/webhooks/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"@oclif/test": "^2.2.20",
"@types/chai": "^4",
"@types/mocha": "^5",
"@types/node": "^10",
"chai": "^4",
"date-fns": "^1.30.1",
"eslint": "^6.7.2",
Expand All @@ -28,7 +27,7 @@
"typescript": "^4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=14"
},
"files": [
"/lib",
Expand Down
15 changes: 0 additions & 15 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2488,21 +2488,6 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.6.8.tgz#e469b4bf9d1c9832aee4907ba8a051494357c12c"
integrity sha512-aX+gFgA5GHcDi89KG5keey2zf0WfZk/HAQotEamsK2kbey+8yGKcson0hbK8E+v0NArlCJQCqMP161YhV6ZXLg==

"@types/node@10.12.24":
version "10.12.24"
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.24.tgz#b13564af612a22a20b5d95ca40f1bffb3af315cf"
integrity sha512-GWWbvt+z9G5otRBW8rssOFgRY87J9N/qbhqfjMZ+gUuL6zoL+Hm6gP/8qQBG4jjimqdaNLCehcVapZ/Fs2WjCQ==

"@types/node@^10":
version "10.14.8"
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.14.8.tgz#fe444203ecef1162348cd6deb76c62477b2cc6e9"
integrity sha512-I4+DbJEhLEg4/vIy/2gkWDvXBOOtPKV9EnLhYjMoqxcRW+TTZtUftkHktz/a8suoD5mUL7m6ReLrkPvSsCQQmw==

"@types/node@^10.12.24":
version "10.14.13"
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.14.13.tgz#ac786d623860adf39a3f51d629480aacd6a6eec7"
integrity sha512-yN/FNNW1UYsRR1wwAoyOwqvDuLDtVXnaJTZ898XIw/Q5cCaeVAlVwvsmXLX5PuiScBYwZsZU4JYSHB3TvfdwvQ==

"@types/node@^15.6.1":
version "15.14.9"
resolved "https://registry.yarnpkg.com/@types/node/-/node-15.14.9.tgz#bc43c990c3c9be7281868bbc7b8fdd6e2b57adfa"
Expand Down

0 comments on commit 2257add

Please sign in to comment.