fix(cli): use uuid rather than addon name for pg:credentials (#2042)

* fix(cli): use uuid rather than addon name for pg:credentials * Update test to mock correct url --------- Co-authored-by: Eric Black <eblack@salesforce.com>
heroku · Mar 8, 2024 · efec095 · efec095
1 parent 3c74d2a
commit efec095
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/pg-v5/commands/credentials.js b/packages/pg-v5/commands/credentials.js
@@ -26,11 +26,11 @@ async function run(context, heroku) {
       return util.presentCredentialAttachments(app, credAttachments, credentials, cred)
     }
 
-    credentials = await heroku.get(`/postgres/v0/databases/${addon.name}/credentials`,
+    credentials = await heroku.get(`/postgres/v0/databases/${addon.id}/credentials`,
       {host: host(addon)})
     let isDefaultCredential = cred => cred.name !== 'default'
     credentials = sortBy(credentials, isDefaultCredential, 'name')
-    attachments = await heroku.get(`/addons/${addon.name}/addon-attachments`)
+    attachments = await heroku.get(`/addons/${addon.id}/addon-attachments`)
 
     cli.warn(`${cli.color.cmd('pg:credentials')} has recently changed. Please use ${cli.color.cmd('pg:credentials:url')} for the previous output.`)
     cli.table(credentials, {

diff --git a/packages/pg-v5/test/unit/commands/credentials.unit.test.js b/packages/pg-v5/test/unit/commands/credentials.unit.test.js
@@ -103,8 +103,8 @@ describe('pg:credentials', () => {
         namespace: 'credential:ransom',
       },
     ]
-    api.get('/addons/postgres-1/addon-attachments').reply(200, attachments)
-    pg.get('/postgres/v0/databases/postgres-1/credentials').reply(200, credentials)
+    api.get('/addons/1/addon-attachments').reply(200, attachments)
+    pg.get('/postgres/v0/databases/1/credentials').reply(200, credentials)
 
     let displayed = `Credential                                                                     State
 ─────────────────────────────────────────────────────────────────────────────  ────────
@@ -179,8 +179,8 @@ ransom                                                                         a
         namespace: 'credential:ransom',
       },
     ]
-    api.get('/addons/postgres-1/addon-attachments').reply(200, attachments)
-    pg.get('/postgres/v0/databases/postgres-1/credentials').reply(200, credentials)
+    api.get('/addons/1/addon-attachments').reply(200, attachments)
+    pg.get('/postgres/v0/databases/1/credentials').reply(200, credentials)
 
     let displayed = `Credential                                            State
 ────────────────────────────────────────────────────  ────────