Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): container:push --recursive behavior #2958

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(cli): container:push --recursive behavior #2958

merged 1 commit into from
Jul 30, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Jul 29, 2024

Description

Gus Item
Fixes #2949

A regression was introduced in 9.0 that made --recursive not push any dockerfiles when process types were not provided. This fixes that bug, and adds a test for this scenario.

Testing

  1. Pull down this branch
  2. Switch to a repository with a Docker-based app and multiple dockerfiles (e.g., Dockerfile.web, Dockerfile.worker)
  3. Run $PATH_TO_CLI/bin/dev --app DOCKER_APP_NAME --recursive
  4. Verify it pushes all Dockerfiles

@eablack eablack self-assigned this Jul 29, 2024
@eablack eablack requested a review from a team as a code owner July 29, 2024 23:30
justinwilaby
justinwilaby approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eablack eablack changed the title FIx container:push --recursive behavior fIx: container:push --recursive behavior Jul 30, 2024
@eablack eablack changed the title fIx: container:push --recursive behavior fIx(cli): container:push --recursive behavior Jul 30, 2024
@eablack eablack changed the title fIx(cli): container:push --recursive behavior fix(cli): container:push --recursive behavior Jul 30, 2024
@eablack eablack merged commit 7363461 into main Jul 30, 2024
7 checks passed
@eablack eablack deleted the eb/fix-container-push-recursively branch July 30, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

Assignees

@eablack eablack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking Change for heroku container:push --recursive on 9.0.0
2 participants
@eablack @justinwilaby