Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Update node version to 20 #2989

Merged
merged 13 commits into from
Sep 10, 2024
Merged

feat(cli): Update node version to 20 #2989

merged 13 commits into from
Sep 10, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Aug 23, 2024 •
edited
Loading

GUS WI

  • Update node engine for the CLI to 20
  • Update node version used in our release and cli workflows to 20
  • Updates versions of actions/checkout and actions/setup-node to v4
  • Cleans up some lint warnings

@eablack eablack requested a review from a team as a code owner August 23, 2024 20:13
@eablack eablack changed the base branch from main to prerelease/10.0.0-alpha September 9, 2024 22:51
sbosio
sbosio requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just one little thing to fix on tests, I guess. But overall it looks great! Fix the tests and I'll be approving. It's exciting to see the update to Node 20 happening!

packages/cli/test/unit/commands/addons/open.unit.test.ts Show resolved Hide resolved
sbosio
sbosio approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@eablack eablack merged commit fece1bc into prerelease/10.0.0-alpha Sep 10, 2024
8 checks passed
@eablack eablack deleted the eb/upgrade-to-node-20 branch September 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eablack @sbosio