fix: quiet option sometimes only working as a flag
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
approved these changes
Aug 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 61.49% 61.46% -0.04%
==========================================
Files 237 237
Lines 8480 8485 +5
==========================================
Hits 5215 5215
- Misses 2560 2564 +4
- Partials 705 706 +1 ☔ View full report in Codecov by Sentry. |
phm07
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.47.0](v1.46.0...v1.47.0) (2024-08-30) ### Features * allow deleting rDNS entries ([#839](#839)) ([129f51d](129f51d)), closes [#814](#814) * **certificate:** allow retrying managed certificate issuance ([#847](#847)) ([0223f7d](0223f7d)) * improve datacenter describe server types readability ([#854](#854)) ([fc0002c](fc0002c)), closes [#852](#852) ### Bug Fixes * `quiet` option sometimes only working as a flag ([#846](#846)) ([f7c9ac6](f7c9ac6)) * **image:** only accept numerical ids for update, delete, label ([#844](#844)) ([7355571](7355571)) * **load-balancer:** show message if none of --server, --label-selector or --ip is set ([#849](#849)) ([2df45e0](2df45e0)) * **primary-ip:** change protection commands do not allow protection levels ([#851](#851)) ([697a87a](697a87a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, the old
Flags().GetBool()was used instead of actually using the option. That causes thequietoption to be ignored in these places if it is set via the config file or environment variables.