-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize hostname check to allow also wildcard certificates #798
Conversation
Ok I already see that I should provide a fallback for older Erlang versions. |
Can you take a look at this @voltone since you created the original PR for mint? |
Hi @voltone, just had time to apply your change requests. Hope that fits and I understood you correctly with regards to the reuse of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that cleans things up nicely. Thanks!
Thank you @imsoulfly and @voltone! 💜 |
Hello everyone,
I already wrote one solution that I took over from the
mint
library to activate validation of wildcard certificates with the now stricter Erlang TLS handling in the issue here: #797But I actually was able to find a better solution of using the wildcard hostname verification directly from the
public_key Erlang module that does to knowledge exactly the same.
Disclaimer: I did manual testing of this but wasn't really able to come up with how to actually test this. Speaking of having a proper test setup that provides a server with wildcard certificate for its domain. If you know a way let me know. For now I can only deliver this 😄
Have a nice day!