Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only process supported Putty v3 keys + minor optimizations #729

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

jpstotz
Copy link
Contributor

@jpstotz jpstotz commented Oct 2, 2021

As mentioned in #716 the current Puttyv3 support is limited to unencrypted key files as the new file format uses Argon based key derivation functions . This PR adds checks so that we do not try to decrypt a key we can never decrypt successfully because of the missing Argon implementation.
Instead a describing exception is thrown so it is clear that the password was not the problem.
A unit test for an encrypted RSA putty v3 key has been added.

Additionally I made some small optimizations on the putty key loading code.

@hierynomus hierynomus merged commit d6d6f0d into hierynomus:master Oct 2, 2021
@hierynomus
Copy link
Owner

Thanks!

@jpstotz jpstotz deleted the puttyv3 branch October 12, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants