Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Unknown Screen. Fixes Issue #161 #163

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Added Unknown Screen. Fixes Issue #161 #163

merged 2 commits into from
Mar 26, 2021

Conversation

SapinderSingh
Copy link
Contributor

Related Issue

Proposed Changes

  • Added Unknown Screen.
  • Created route constant for the screen in constants.dart.
  • Linked route for the screen in default case in route_page.dart

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Follows linting rules
    WhatsApp Image 2021-03-26 at 12 05 28

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Mar 26, 2021
himanshusharma89
himanshusharma89 requested changes Mar 26, 2021
View reviewed changes
lib/helpers/constants.dart Outdated Show resolved Hide resolved
@himanshusharma89 himanshusharma89 added the Level1 easy gssoc issue label Mar 26, 2021
@himanshusharma89 himanshusharma89 merged commit 9c28ee5 into himanshusharma89:master Mar 26, 2021
@SapinderSingh SapinderSingh deleted the issue-161 branch March 27, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshusharma89 himanshusharma89 himanshusharma89 requested changes

Assignees

@SapinderSingh SapinderSingh

Labels
GSSOC21 Issues created for GSSOC'21 Level1 easy gssoc issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App is using a Text Widget for unknown route instead of a screen.
2 participants
@SapinderSingh @himanshusharma89