Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding score function code (and U-Net code) for pixel single-integrator. #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gchou95
Copy link
Collaborator

@gchou95 gchou95 commented May 8, 2023

I more or less copied Yang Song's U-Net architectures verbatim, so I added a compatible variant of the the Langevin dynamics code and created a new NCSN class specifically for images, which has different loss function code.

Let me know if you'd prefer if I try to rewrite everything in the original code structure.


This change is Reviewable

@gchou95 gchou95 requested a review from hjsuh94 May 8, 2023 17:43
Copy link
Owner

@hjsuh94 hjsuh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Glen! This looks good for our purpose.

I think we might keep the image part of nn.py in a different file? It might make the code a bit cleaner in that file.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @gchou95)


score_po/nn.py line 489 at r1 (raw file):

    return (sigma_max - sigma_min) * x + sigma_min

############################################ Image-based networks ############################################

Perhaps it's good to separate this part into another file (image_nn.py)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants