This repository has been archived by the owner on Feb 8, 2021. It is now read-only.
Swift 4 and Xcode 9 #307
Merged
Swift 4 and Xcode 9 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkellaway looks like it passed! |
|
@andrewjmeier great! can you actually re-submit this PR against the after merging that, i'll attempt to release a beta version to cocoapods until then, you can always point to your own Gloss branch/commit in your applicatin's Podfile to continue using the library (unless you're using it as a subspec in your own pod) |
|
@hkellaway I changed the branch to |
|
@andrewjmeier this is no longer passing Travis :/ |
|
Ah rip. @hkellaway hopefully that fixes it. I didn't realize there were already changes in the swift 4 branch. |
|
fyi - version |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.