Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client request(s) and server response(s) are not displayed for failed tests. #71

Open
StephThaoOng opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request Priority::Low

Comments

@StephThaoOng
Copy link
Collaborator

Currently, client request(s) and server response(s) are not displayed for any failed tests.
Example:
InfernoIssue01

Request for a fix to display request(s) and response(s) for all tests, where applicable, even for failed tests.

@StephThaoOng StephThaoOng added the enhancement New feature or request label Apr 24, 2024
@projkov projkov self-assigned this Apr 26, 2024
@projkov
Copy link
Collaborator

projkov commented Apr 26, 2024

Hello @StephThaoOng

There is no output of request and response because, in this particular case, the request was not sent. This test is not running because there is no data for the search parameters (patient or date) for the current search test.

This information is automatically retrieved from the previous responses. It may be missing the date for the Procedure resources that were in the previous responses.

@StephThaoOng
Copy link
Collaborator Author

Thanks @projkov.

I can see that the narrative under section "Testing Methodology > Searching > Search Parameters" is intended to call out the dependencies between tests so that it is made known to users.

Can we consider uplifting these narratives so that they are specific to each test suite/sequence?
i.e. the current narrative in the Procedure Tests reads "...For example, the identifier search in the patient sequence is performed by looking for an existing Patient.identifier from any of the resources returned in the _id search. If a value cannot be found this way, the search is skipped." which doesn't seem applicable to the Procedure Tests.

projkov added a commit that referenced this issue Sep 16, 2024
projkov added a commit that referenced this issue Sep 16, 2024
projkov added a commit that referenced this issue Sep 16, 2024
projkov added a commit that referenced this issue Sep 17, 2024
@projkov
Copy link
Collaborator

projkov commented Sep 17, 2024

@StephThaoOng Hello Steph

I made a list of errors that can be raised in tests. Could you please review them and maybe highlight unclear error texts for users?
https://github.com/hl7au/au-fhir-core-inferno/blob/master/docs/errors_list.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority::Low
Projects
None yet
Development

No branches or pull requests

2 participants