Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10816 Fix for error updating representative #1413

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Jul 12, 2024

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10816

Change description

  • Remove V1 logic from IsRoleRepresentative (which uses case role/party). This doesn't work on V2
  • Update tests to use V2 roles
  • Fix flush error

Copy link

sonarcloud bot commented Jul 12, 2024

@oliver-scott oliver-scott marked this pull request as ready for review July 12, 2024 15:52
@oliver-scott oliver-scott requested review from a team as code owners July 12, 2024 15:52
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. Nice to work through some house keeping, even if it's through bug tickets 😅

@oliver-scott oliver-scott merged commit bb311e7 into master Jul 15, 2024
13 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-10816-rep-booking-error branch July 15, 2024 13:36
oliver-scott added a commit that referenced this pull request Jul 15, 2024
* Fix issue

* Remove redundant argument

* Lint

* Fix flush error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants