-
-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aiohttp to 3.9.0b0 #101627
Update aiohttp to 3.9.0b0 #101627
Conversation
Hey there @davet2001, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Upgrading to a beta release is a bit unusual, but there is a lot of special cases for aiohttp already, and as you point out we can revert it before the next release if needed. I think its better to at least get some testing and discover the problems sooner rather than later so it seems fine as long as we revert this PR before the end of HA beta if 3.9.0 isn't officially released by than. |
I'm going to push this to my production and report back |
So far so good on two production systems. Going to push wider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working just fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's do it and re-evaluate before beta.
../Frenck
# Overwrite base aiohttp _wait implementation | ||
# Homeassistant has a custom shutdown wait logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdce8p Would a cleaner approach work by just setting shutdown_timeout to 0?
If not, then maybe there are some improvements to be made in aiohttp...
I'd also be curious how homeassistant's shutdown logic works.
Proposed change
https://github.com/aio-libs/aiohttp/releases/tag/v3.9.0b0
https://github.com/aio-libs/aiohttp/blob/v3.9.0b0/CHANGES.rst#390b0-2023-10-07
This might be a bit unusual. How about we upgrade to the beta version for
aiohttp
and see how it goes?Version
3.9.0
will be required for Python 3.12, so this would allow us to start testing it (unofficially). Furthermore, if there are any issues withb0
, we'll have almost three weeks of testing to find out. Since it's almost fully compatible with3.8
, we could just revert this PR either completely or just for the next release if it doesn't work out / we find something unexpected.There are some (optional) changes to improve the typing of the
app
data. I'd propose to wait with those until after we've moved to the final3.9.0
release. https://docs.aiohttp.org/en/latest/web_advanced.html#application-s-configWheels are already up on: https://wheels.home-assistant.io/musllinux/
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: