Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump evohome-async to 0.4.6 #103534

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Bump evohome-async to 0.4.6 #103534

merged 3 commits into from
Nov 6, 2023

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Nov 6, 2023

This PR relaxes the requirements of evohome-async, which included hard-pinned versions of aiohttp. See: #103507

zxdavb/evohome-async@0.4.4...0.4.6

See: zxdavb/evohome-async#11

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wondering, since you're working on typing. Don't you need to include a py.typed file? https://peps.python.org/pep-0561/

@zxdavb zxdavb marked this pull request as draft November 6, 2023 18:23
@zxdavb
Copy link
Contributor Author

zxdavb commented Nov 6, 2023

Don't you need to include a py.typed file?

I didn't know then about that file, but found out quickly enough.

When I added one, all hell broke loose, so it is going to take a while to sort that out.

@zxdavb
Copy link
Contributor Author

zxdavb commented Nov 6, 2023

I have had to add some type hints in too.

@zxdavb zxdavb marked this pull request as ready for review November 6, 2023 20:40
@jpbede jpbede merged commit af4ccef into home-assistant:dev Nov 6, 2023
53 checks passed
@zxdavb zxdavb deleted the evo_bump_client branch November 6, 2023 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants