Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.10.0b1 #122409

Merged
merged 14 commits into from
Jul 23, 2024
Merged

Bump aiohttp to 3.10.0b1 #122409

merged 14 commits into from
Jul 23, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 22, 2024

Proposed change

changelog: aio-libs/aiohttp@v3.9.5...v3.10.0b1

tracking issue aio-libs/aiohttp#8529

We expect to be able to do the 3.10.x release later this week. It would be good to get this in a nightly to get feedback ahead of that to make it easier to test. We can always revert it if there is an issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Jul 22, 2024
bdraco added a commit to bdraco/async_upnp_client that referenced this pull request Jul 22, 2024
@bdraco bdraco marked this pull request as ready for review July 23, 2024 14:05
@bdraco bdraco requested a review from a team as a code owner July 23, 2024 14:05
@steverep
Copy link
Member

Per #121831, a change should be made to homeassistant/components/http/static.py here to at least:

# remove import mimetypes
from aiohttp.web_fileresponse import CONTENT_TYPES
# swap mimetypes.guess_type for CONTENT_TYPES.guess_type

Alternatively, much of the handler override can be removed now that 3.10 does the file operations in an executor.

@bdraco
Copy link
Member Author

bdraco commented Jul 23, 2024

Per #121831, a change should be made to homeassistant/components/http/static.py here to at least:

# remove import mimetypes
from aiohttp.web_fileresponse import CONTENT_TYPES
# swap mimetypes.guess_type for CONTENT_TYPES.guess_type

Alternatively, much of the handler override can be removed now that 3.10 does the file operations in an executor.

Let's do that in another PR in case we need to revert this before release

@bdraco bdraco merged commit 6bdc5be into dev Jul 23, 2024
40 checks passed
@bdraco bdraco deleted the aiohttp310b1 branch July 23, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants