Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix IndexError in Opower #124478

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented Aug 23, 2024

Breaking change

Proposed change

Attempt to fix #123208
Line 113 calls get_last_statistics on cost_statistic_id. Under normal conditions the start time should match between cost and consumption statistics. My guess is that the first async_add_external_statistics call failed which caused IndexError at the next retry. Now we call get_last_statistics on the last inserted statistic, i.e. consumption instead of cost.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tronikos tronikos changed the title Change the order of async_add_external_statistics in Opower Attempt to fix IndexError in Opower Aug 26, 2024
@tronikos tronikos marked this pull request as ready for review August 26, 2024 23:56
@joostlek
Copy link
Member

Should we have this in the beta?

@tronikos tronikos added this to the 2024.9.0 milestone Aug 30, 2024
@tronikos tronikos merged commit 910fb09 into home-assistant:dev Aug 30, 2024
25 of 26 checks passed
@tronikos tronikos deleted the opower_order branch August 30, 2024 15:34
bramkragten pushed a commit that referenced this pull request Aug 30, 2024
* Change the order of async_add_external_statistics in Opower

* Use consumption_statistic_id instead of cost_statistic_id
synesthesiam pushed a commit that referenced this pull request Aug 30, 2024
* Change the order of async_add_external_statistics in Opower

* Use consumption_statistic_id instead of cost_statistic_id
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opower stopped initializing w/ Seattle City Light
3 participants