Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] GitHub actions simplifications #38671

Conversation

basnijholt
Copy link
Contributor

@basnijholt basnijholt commented Aug 8, 2020

Proposed change

This simplifies the CI workflows by defining reusable actions that combine steps.

The functionality for this to work has been implemented by GitHub, but it didn't make it to production yet.

I marked it as BLOCKED to indicate that this is waiting for GH.

References:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 8, 2020
@frenck
Copy link
Member

frenck commented Aug 8, 2020

This is not reusable at this point. A) the feature isn't released yet (+ other features that are more interesting are coming).

Lastly, the part you are extracting for "re-use" cannot be reused as they contain specifics for the Home Assistant core repo.

My suggestion would be to open such a PR when it is ready to be implemented and close this one in the mean time.

@MartinHjelmare
Copy link
Member

Let's close here for now. We're trying to decrease our open PR buffer. We can look at this again when the feature is more mature. Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants