Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump orjson to 3.9.7 #99938

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Bump orjson to 3.9.7 #99938

merged 1 commit into from
Sep 8, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 8, 2023 •
edited
Loading

needs https://github.com/home-assistant/core/actions/runs/6124466989

Proposed change

changelog: ijl/orjson@3.9.2...3.9.7

Bump again now that ijl/orjson#415 is fixed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Bump orjson to 3.9.7
47de390 
changelog: ijl/orjson@3.9.2...3.9.7

Bump again now that ijl/orjson#415 is fixed
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Sep 8, 2023
@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

cc @cdce8p since this is on your py3.12 list

@bdraco bdraco closed this Sep 8, 2023
@bdraco bdraco reopened this Sep 8, 2023
@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

Its not actually on pypi yet so will need to restart the ci again when orjson's actions finishes

@bdraco bdraco closed this Sep 8, 2023
@bdraco bdraco reopened this Sep 8, 2023
@bdraco bdraco closed this Sep 8, 2023
@bdraco bdraco reopened this Sep 8, 2023
@bdraco bdraco closed this Sep 8, 2023
@bdraco bdraco reopened this Sep 8, 2023
@cdce8p cdce8p closed this Sep 8, 2023
@cdce8p cdce8p reopened this Sep 8, 2023
@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

pypi seems to be extra slow today

@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

might actually be something wrong with pypi since home-assistant/supervisor#4543 failed as well

@cdce8p
Copy link
Member

cdce8p commented Sep 8, 2023

It should work now. Just checked the CI job and the download of orjson worked. Just need to wait for it to finish now.

@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

checkout barfed. github hates us today

@bdraco bdraco closed this Sep 8, 2023
@bdraco bdraco reopened this Sep 8, 2023
@cdce8p cdce8p marked this pull request as ready for review September 8, 2023 17:54
@cdce8p cdce8p requested a review from a team as a code owner September 8, 2023 17:54
@cdce8p cdce8p marked this pull request as draft September 8, 2023 17:55
@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

still doing testing on my productions with this.

Will merge in a few hours if everything ok

@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2023

All good after 30 restarts.

It crashed after 5-6 before

@bdraco bdraco marked this pull request as ready for review September 8, 2023 18:59
@bdraco bdraco merged commit f0ee20c into dev Sep 8, 2023
120 of 129 checks passed
@bdraco bdraco deleted the orjson_397 branch September 8, 2023 18:59
@cdce8p
Copy link
Member

cdce8p commented Sep 8, 2023

Thanks @bdraco 👍🏻

@cdce8p cdce8p mentioned this pull request Sep 8, 2023
Closed
32 tasks
@github-actions GitHub Actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @cdce8p