Ensure empty body responses never generate an invalid chunked response #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiohttp < 3.9.0 will generate an invalid chunked response if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send a StreamResponse when a normal Response will do. When we upgrade to 3.9.0 we should replace this check with the aiohttp must_be_empty_body helper: https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
20 tasks
aiohttp < 3.9.0 will generate an invalid chunked response if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send a StreamResponse when a normal Response will do. When we upgrade to 3.9.0 we should replace this check with the aiohttp must_be_empty_body helper: https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
aiohttp < 3.9.0 will generate an invalid chunked response if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send a StreamResponse when a normal Response will do. When we upgrade to 3.9.0 we should replace this check with the aiohttp must_be_empty_body helper: https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
aiohttp < 3.9.0 will generate an invalid chunked response if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send a StreamResponse when a normal Response will do. When we upgrade to 3.9.0 we should replace this check with the aiohttp must_be_empty_body helper: https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
aiohttp < 3.9.0 will generate an invalid chunked response if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send a StreamResponse when a normal Response will do. When we upgrade to 3.9.0 we should replace this check with the aiohttp must_be_empty_body helper: https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
frenck
approved these changes
Nov 15, 2023
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
aiohttp < 3.9.0 (fixed in aio-libs/aiohttp#7756) will generate an invalid chunked response aka
"0\r\n\r\n"instead of an actual empty body if we reached the streaming handler for 204, 304, and a few other cases. Additionally its inefficient to send aStreamResponsewhen a normalResponsewill do in these cases.I tested this changed with core running aiohttp 3.9.0rc0 and 3.8.5, and supervisor running aiohttp 3.8.6 and 3.9.0rc0
When we upgrade to 3.9.0 we should replace this check with the aiohttp
must_be_empty_bodyhelper:https://github.com/aio-libs/aiohttp/blob/8ae650bee4add9f131d49b96a0a150311ea58cd1/aiohttp/helpers.py#L1061
Type of change
Additional information
Checklist
black --fast supervisor tests)If API endpoints of add-on configuration are added/changed: