Change dyff to be kubectl diff compatible (#148) #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #148 Introduce special case logic to rearrange the program arguments to match the expected `dyff between --flags from to` style in case the `dyff` is used in the `KUBECTL_EXTERNAL_DIFF` Change exit code created by `dyff` to be aligned with `kubectl diff` expectations in terms of error codes for changes vs program errors. Rename `--set-exit-status` to `--set-exit-code` since this is the better terminology in shell context. Deprecate `--set-exit-status` flag. Bump to github.com/gonvenience/ytbx v1.4.0 to support reading from directories instead of just files. Change named entry list candidates logic to optionally include extra candidate in case the Kubernetes flag is used. Add README section with `kubectl` use case.
Codecov Report
@@ Coverage Diff @@
## develop #149 +/- ##
===========================================
+ Coverage 81.66% 82.03% +0.36%
===========================================
Files 12 12
Lines 1069 1102 +33
===========================================
+ Hits 873 904 +31
- Misses 148 149 +1
- Partials 48 49 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Introduce special case logic to rearrange the program arguments to match
the expected
dyff between --flags from tostyle in case thedyffisused in the
KUBECTL_EXTERNAL_DIFFChange exit code created by
dyffto be aligned withkubectl diffexpectations in terms of error codes for changes vs program errors.
Rename
--set-exit-statusto--set-exit-codesince this is the betterterminology in shell context. Deprecate
--set-exit-statusflag.Bump to github.com/gonvenience/ytbx v1.4.0 to support reading from
directories instead of just files.
Change named entry list candidates logic to optionally include extra
candidate in case the Kubernetes flag is used.
Add README section with
kubectluse case.