Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showImages/hosts: Update Imgur #5536

Merged

Conversation

larsjohnsen
Copy link
Collaborator

  • Fixes video retrieval (the API no longer contains the property gifv)
  • Removes option useGifOverGifv which seemingly is broken
  • Removes redundant protocol replacement, as Imgur now always responds with https

Relevant issue: https://www.reddit.com/r/RESissues/comments/1exm5b7/imgur_gifgifvmp4_expandos_broken/
Tested in browser: Chrome 128

- Fixes video retrieval (the API no longer contains the property `gifv`)
- Removes options `useGifOverGifv` which seemingly is brokes
- Removes redundant protocol replacement, as imgur now always responds with https
@benmcgarry
Copy link
Collaborator

This good to merge? If so can and i'll push a release.

@larsjohnsen
Copy link
Collaborator Author

This good to merge? If so can and i'll push a release.

Yes, it seems good.

@benmcgarry benmcgarry merged commit 3cbecf3 into honestbleeps:master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants