stacktrace: Remove dangerous value access #29
Conversation
|
Thanks. I'll have a look later. |
|
Case 1: Success |
src/stacktrace.cc
Outdated
| if (dlip.dli_sname != NULL && dlip.dli_saddr != NULL) { | ||
| symbol = abi::__cxa_demangle(dlip.dli_sname, 0, 0, &status); | ||
| if (status != 0) | ||
| symbol = strdup(dlip.dli_sname); |
There was a problem hiding this comment.
I think this change is not needed because we already added return value check of dladdr above.
There was a problem hiding this comment.
There could be a case that dladdr could return non-zero value but dli_sname and dli_saddr is NULL. You can find that case on commit message "Case 2: Failed to get symbol but succeed to get shared object".
dladdr function could be failed. There could be only three cases. Followings are the way to print for each cases. Consider symbol name as A, symbol offset as B, shared object name as C and shared object offset as D Case 1: Success A +B (C +D) Case 2: Failed to get symbol but succeed to get shared object (C +D) Case 3: Failed to get symbol as well as shared object unknown Signed-off-by: Bojun Seo <bojun.seo.0@gmail.com>
dlip.dli_fnamecould beNULL.So add null check before use this value.