Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): remove deprecated address type #3115

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Jul 8, 2024

In #2958, we plan to remove an unnecessary address type.
So this PR removes it from vercel adapter.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (fbae337) to head (dab557a).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3115      +/-   ##
==========================================
- Coverage   96.15%   96.15%   -0.01%     
==========================================
  Files         144      145       +1     
  Lines       14748    14757       +9     
  Branches     2603     2590      -13     
==========================================
+ Hits        14181    14189       +8     
- Misses        567      568       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jul 8, 2024

@ryuapp

Thanks!

@yusukebe yusukebe merged commit 74310f4 into honojs:next Jul 8, 2024
14 checks passed
@ryuapp ryuapp deleted the fix-conninfo branch July 9, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants