fix(middleware/jwt): Changed the jwt-secret type to SignatureKey #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerZade
suggested changes
Jul 20, 2024
src/middleware/jwt/jwt.ts
Outdated
| @@ -11,6 +11,7 @@ import type { CookiePrefixOptions } from '../../utils/cookie' | |||
| import { Jwt } from '../../utils/jwt' | |||
| import '../../context' | |||
| import type { SignatureAlgorithm } from '../../utils/jwt/jwa' | |||
| import { SignatureKey } from '../../utils/jwt/jws' | |||
There was a problem hiding this comment.
Suggested change
| import { SignatureKey } from '../../utils/jwt/jws' | |
| import type { SignatureKey } from '../../utils/jwt/jws' |
yusukebe
changed the title
|
Hi @JulesVerner Thank you for the PR. Looks good. One thing. Could you run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 151 151
Lines 15056 15057 +1
Branches 2607 2606 -1
=======================================
+ Hits 14482 14483 +1
Misses 574 574 ☔ View full report in Codecov by Sentry. |
|
@JulesVerner Thanks! I'll merge this now. |
adamnolte
pushed a commit
to autoblocksai/cli
that referenced
this pull request
Jul 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hono](https://hono.dev/) ([source](https://github.com/honojs/hono)) | [`4.4.7` -> `4.5.1`](https://renovatebot.com/diffs/npm/hono/4.4.7/4.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/hono (hono)</summary> ### [`v4.5.1`](https://github.com/honojs/hono/releases/tag/v4.5.1) [Compare Source](https://github.com/honojs/hono/compare/v4.5.0...v4.5.1) #### What's Changed - chore: remove rimraf and use bun shell by [@​nakasyou](https://github.com/nakasyou) in [honojs/hono#3146 - chore: moving the setup file of vitest by [@​EdamAme-x](https://github.com/EdamAme-x) in [honojs/hono#3157 - fix(middleware/jwt): Changed the jwt-secret type to SignatureKey by [@​JulesVerner](https://github.com/JulesVerner) in [honojs/hono#3167 - feat(bearer-auth): Allow empty bearer-auth middleware prefixes by [@​prevostc](https://github.com/prevostc) in [honojs/hono#3161 - chore(factory): remove `@experimental` from `createApp` by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3164 - fix(client): support array values for `query` in `ws` by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3169 - fix(validator): ignore content-type mismatches by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3165 #### New Contributors - [@​JulesVerner](https://github.com/JulesVerner) made their first contribution in [honojs/hono#3167 - [@​prevostc](https://github.com/prevostc) made their first contribution in [honojs/hono#3161 **Full Changelog**: honojs/hono@v4.5.0...v4.5.1 ### [`v4.5.0`](https://github.com/honojs/hono/compare/v4.4.13...v4.5.0) [Compare Source](https://github.com/honojs/hono/compare/v4.4.13...v4.5.0) ### [`v4.4.13`](https://github.com/honojs/hono/releases/tag/v4.4.13) [Compare Source](https://github.com/honojs/hono/compare/v4.4.12...v4.4.13) ##### What's Changed - chore: update benchmark by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3102 - chore: replace tsx with Bun by [@​nakasyou](https://github.com/nakasyou) in [honojs/hono#3103 - refactor(http-status): remove unnecessary line of types and use common types by [@​EdamAme-x](https://github.com/EdamAme-x) in [honojs/hono#3110 - fix(jsx): redefine scope attribute as enum type by [@​yasuaki640](https://github.com/yasuaki640) in [honojs/hono#3118 - fix(types): allow `string[] | File[]` for RPC form value by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3117 - fix(validator-types): type Alignment with Web Standards by [@​EdamAme-x](https://github.com/EdamAme-x) in [honojs/hono#3120 - fix(types): `app.use(path, mw)` return correct schema type by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3128 **Full Changelog**: honojs/hono@v4.4.12...v4.4.13 ### [`v4.4.12`](https://github.com/honojs/hono/releases/tag/v4.4.12) [Compare Source](https://github.com/honojs/hono/compare/v4.4.11...v4.4.12) #### What's Changed - fix(aws-lambda): set cookies with comma is bugged by [@​NamesMT](https://github.com/NamesMT) in [honojs/hono#3084 - fix(types): infer `path` when chaining after `use` by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3087 - chore: update outdated links in JSDoc by [@​ryuapp](https://github.com/ryuapp) in [honojs/hono#3089 - fix(jsx): changes behavior when `download` attribute is set to a boolean value. by [@​oon00b](https://github.com/oon00b) in [honojs/hono#3094 - chore: add the triage label by [@​mvares](https://github.com/mvares) in [honojs/hono#3092 - feat(types): improve JSONParsed by [@​m-shaka](https://github.com/m-shaka) in [honojs/hono#3074 - fix(helper/streaming): remove slow types by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3100 - chore(utils/jwt): add `@module` docs by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3101 #### New Contributors - [@​oon00b](https://github.com/oon00b) made their first contribution in [honojs/hono#3094 **Full Changelog**: honojs/hono@v4.4.11...v4.4.12 ### [`v4.4.11`](https://github.com/honojs/hono/releases/tag/v4.4.11) [Compare Source](https://github.com/honojs/hono/compare/v4.4.10...v4.4.11) #### What's Changed - refactor: remove unnecessary async keyword from router tests by [@​K-tecchan](https://github.com/K-tecchan) in [honojs/hono#3061 - fix(validator): don't return a FormData if formData is cached by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3067 - fix(client): Add Query Parameter Support to WebSocket Client in `hono/client` by [@​naporin0624](https://github.com/naporin0624) in [honojs/hono#3066 - refactor(types): move `HandlerInterface`'s `(path, handler)`s overloads down by [@​NamesMT](https://github.com/NamesMT) in [honojs/hono#3072 - test(helper/dev): fix typo of test case name by [@​yasuaki640](https://github.com/yasuaki640) in [honojs/hono#3073 - fix(stream): Fixed a problem that onAbort() is called even if request is normally closed in deno by [@​usualoma](https://github.com/usualoma) in [honojs/hono#3079 #### New Contributors - [@​K-tecchan](https://github.com/K-tecchan) made their first contribution in [honojs/hono#3061 **Full Changelog**: honojs/hono@v4.4.10...v4.4.11 ### [`v4.4.10`](https://github.com/honojs/hono/releases/tag/v4.4.10) [Compare Source](https://github.com/honojs/hono/compare/v4.4.9...v4.4.10) #### What's Changed - chore(jsr): export JWT utils by [@​ryuapp](https://github.com/ryuapp) in [honojs/hono#3056 - fix(streaming): call stream.abort() explicitly when request is aborted by [@​usualoma](https://github.com/usualoma) in [honojs/hono#3042 - fix(client): set Path as the default of Original by [@​m-shaka](https://github.com/m-shaka) in [honojs/hono#3058 #### New Contributors - [@​m-shaka](https://github.com/m-shaka) made their first contribution in [honojs/hono#3058 **Full Changelog**: honojs/hono@v4.4.9...v4.4.10 ### [`v4.4.9`](https://github.com/honojs/hono/releases/tag/v4.4.9) [Compare Source](https://github.com/honojs/hono/compare/v4.4.8...v4.4.9) #### What's Changed - perf(context): improve initializing `Context` by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3046 - fix(types): correct inferring env when routes channing by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3051 - docs: update the description of `package.json` and README by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3052 - fix(timing): prevent duplicate applications by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3054 **Full Changelog**: honojs/hono@v4.4.8...v4.4.9 ### [`v4.4.8`](https://github.com/honojs/hono/releases/tag/v4.4.8) [Compare Source](https://github.com/honojs/hono/compare/v4.4.7...v4.4.8) #### What's Changed - fix(jsx): add an explicit type by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3007 - ci: use `env` for codecov GitHub Actions by [@​yusukebe](https://github.com/yusukebe) in [honojs/hono#3010 - chore: Fix typos in JSDoc by [@​NicoPlyley](https://github.com/NicoPlyley) in [honojs/hono#3002 - fix: change to allow use of websocket options by [@​EdamAme-x](https://github.com/EdamAme-x) in [honojs/hono#2999 - perf: parseAccept without spread operator by [@​Jayllyz](https://github.com/Jayllyz) in [honojs/hono#3003 - test: add tests for buffer.ts by [@​yasuaki640](https://github.com/yasuaki640) in [honojs/hono#3004 - chore: upload bun test coverage to CodeCov by [@​exoego](https://github.com/exoego) in [honojs/hono#3022 - refactor: remove unneeded import statements by [@​EdamAme-x](https://github.com/EdamAme-x) in [honojs/hono#3014 - perf(utils/buffer): use promise all for better performance by [@​yasuaki640](https://github.com/yasuaki640) in [honojs/hono#3031 **Full Changelog**: honojs/hono@v4.4.7...v4.4.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 17, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the JWT-middleware secret to be a
SignatureKey, instead of being limited to astring.Since the secret is only passed to
Jwt.verify, which already takes aSignatureKey, the parameter for the middleware should match.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code