Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(csrf) fix typo of csrf middleware #3178

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix:(csrf) fix typo of csrf middleware #3178

merged 1 commit into from
Jul 23, 2024

Conversation

yasuaki640
Copy link
Contributor

@yasuaki640 yasuaki640 commented Jul 22, 2024 •
edited
Loading

There was a section that appeared to be a naming discrepancy, which has been corrected.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yasuaki640 yasuaki640 changed the title Fix/typo csrf middleware fix:(csrf) fix typo of csrf middleware Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (2d01359) to head (127d29d).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
+ Coverage   95.87%   96.20%   +0.33%     
==========================================
  Files         137      151      +14     
  Lines       13514    15068    +1554     
  Branches     2300     2623     +323     
==========================================
+ Hits        12956    14496    +1540     
- Misses        558      572      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usualoma
Copy link
Member

Hi, @yasuaki640, Thank you!

yusukebe
yusukebe approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@yasuaki640 Thanks!

@yusukebe yusukebe merged commit e8118e3 into honojs:main Jul 23, 2024
14 checks passed
adamnolte pushed a commit to autoblocksai/cli that referenced this pull request Aug 9, 2024
@renovate
Update dependency hono to v4.5.4 (#114)
c750f36 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://github.com/honojs/hono))
| [`4.5.1` ->
`4.5.4`](https://renovatebot.com/diffs/npm/hono/4.5.1/4.5.4) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.5.1/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.5.1/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.5.4`](https://github.com/honojs/hono/releases/tag/v4.5.4)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.3...v4.5.4)

##### What's Changed

- fix(jsx): corrects the type of 'draggable' attribute in
intrinsic-elements.ts by
[@&#8203;yasuaki640](https://github.com/yasuaki640) in
[honojs/hono#3224
- feat(jsx): allow to merge CSSProperties declaration by
[@&#8203;jonasnobile](https://github.com/jonasnobile) in
[honojs/hono#3228
- feat(client): Add WebSocket Provider Integration Tests and Enhance
WebSocket Initialization by
[@&#8203;naporin0624](https://github.com/naporin0624) in
[honojs/hono#3213
- fix(types): `param` in `ValidationTargets` supports optional param by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3229

##### New Contributors

- [@&#8203;jonasnobile](https://github.com/jonasnobile) made their
first contribution in
[honojs/hono#3228

**Full Changelog**:
honojs/hono@v4.5.3...v4.5.4

### [`v4.5.3`](https://github.com/honojs/hono/releases/tag/v4.5.3)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.2...v4.5.3)

#### What's Changed

- fix(validator): Add double quotation marks to multipart checker regex
by [@&#8203;CPlusPatch](https://github.com/CPlusPatch) in
[honojs/hono#3195
- fix(validator): support `application/json` with a charset as JSON by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3199
- fix(jsx): fix handling of SVG elements in JSX. by
[@&#8203;usualoma](https://github.com/usualoma) in
[honojs/hono#3204
- fix(jsx/dom): fix performance issue with adding many new node listings
by [@&#8203;usualoma](https://github.com/usualoma) in
[honojs/hono#3205
- fix(service-worker): refer to `self.fetch` correctly by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3200

#### New Contributors

- [@&#8203;CPlusPatch](https://github.com/CPlusPatch) made their first
contribution in
[honojs/hono#3195

**Full Changelog**:
honojs/hono@v4.5.2...v4.5.3

### [`v4.5.2`](https://github.com/honojs/hono/releases/tag/v4.5.2)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.1...v4.5.2)

#### What's Changed

- fix(helper/adapter): don't check `navigator` is `undefined` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3171
- fix(types): handle readonly array correctly by
[@&#8203;m-shaka](https://github.com/m-shaka) in
[honojs/hono#3172
- Revert "fix(helper/adapter): don't check `navigator` is `undefined` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3173
- fix(type): degradation of generic type handling by
[@&#8203;m-shaka](https://github.com/m-shaka) in
[honojs/hono#3138
- fix:(csrf) fix typo of csrf middleware by
[@&#8203;yasuaki640](https://github.com/yasuaki640) in
[honojs/hono#3178
- feat(secure-headers): remove "X-Powered-By" should be an option by
[@&#8203;EdamAme-x](https://github.com/EdamAme-x) in
[honojs/hono#3177

**Full Changelog**:
honojs/hono@v4.5.1...v4.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 17, 2024
Open
Open
Open
@Laurry-gee Laurry-gee mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusukebe yusukebe yusukebe approved these changes

@harshsbhat harshsbhat harshsbhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yasuaki640 @usualoma @yusukebe @harshsbhat