Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsx/dom): fix performance issue with adding many new node listings #3205

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(jsx/dom): fix performance issue with adding many new node listings #3205

merged 2 commits into from
Jul 29, 2024

Commits on Jul 29, 2024

  1. fix(jsx/dom): fix performance issue with adding many new node listings 

    * First time rendering does not need to look for elements from child nodes
** Avoid unnecessary checks with `node.pP`.
* Sibling elements are always searched, so there is no need for a for loop.
** Need only `findInsertBefore(node.vC[0])`
    @usualoma
    usualoma committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    48cde49 View commit details
    Browse the repository at this point in the history

  2. test(jsx/dom): add test for performance

    @usualoma
    usualoma committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0784652 View commit details
    Browse the repository at this point in the history