Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve-static): supports directory contains . and not end / #3256

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

yusukebe
Copy link
Member

Fixes #3238

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (8ba0227) to head (434e12a).

Files Patch % Lines
src/adapter/deno/serve-static.ts 0.00% 10 Missing ⚠️
src/adapter/bun/serve-static.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
- Coverage   96.23%   96.19%   -0.05%     
==========================================
  Files         151      151              
  Lines       15197    15228      +31     
  Branches     2639     2762     +123     
==========================================
+ Hits        14625    14648      +23     
- Misses        572      580       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe changed the title fix(serve-static):supports directory contains . and not ends / fix(serve-static): supports directory contains . and not end / Aug 10, 2024
@yusukebe yusukebe merged commit 7a254bc into main Aug 11, 2024
14 checks passed
@yusukebe yusukebe deleted the fix/serve-static-dot-slash branch August 11, 2024 04:01
adamnolte pushed a commit to autoblocksai/cli that referenced this pull request Aug 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://github.com/honojs/hono))
| [`4.5.4` ->
`4.5.5`](https://renovatebot.com/diffs/npm/hono/4.5.4/4.5.5) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.5.4/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.5.4/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.5.5`](https://github.com/honojs/hono/releases/tag/v4.5.5)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.4...v4.5.5)

#### What's Changed

- fix(jsx): allow null, undefined, and boolean to be returned from
function component by [@&#8203;usualoma](https://github.com/usualoma)
in
[honojs/hono#3241
- feat(context): Add types for `c.header` by
[@&#8203;nakasyou](https://github.com/nakasyou) in
[honojs/hono#3221
- fix(jsx): fix draggable type to accept boolean by
[@&#8203;yasuaki640](https://github.com/yasuaki640) in
[honojs/hono#3253
- feat(context): add Context-Type types to `c.header` by
[@&#8203;nakasyou](https://github.com/nakasyou) in
[honojs/hono#3255
- fix(serve-static): supports directory contains `.` and not end `/` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[honojs/hono#3256

**Full Changelog**:
honojs/hono@v4.5.4...v4.5.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serveStatic middleware doesn't work with urls with trailing slashes
1 participant