Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): migrate to vitest v2 #3326

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

yasuaki640
Copy link
Contributor

Migrated to vitest v2.

Details of changes

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

const name = [...suites.slice(3).map((s) => s.name), task.name].join(' > ')
const name = [...suites.slice(2).map((s) => s.name), task.name].join(' > ')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasuaki640 yasuaki640 changed the title Migrate vitest v2 20240823 chore(test): Migrate vitest v2 20240823 Aug 27, 2024
@yasuaki640 yasuaki640 changed the title chore(test): Migrate vitest v2 20240823 chore(test): migrate to vitest v2 Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (f9349ec) to head (7c55a59).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   96.32%   95.75%   -0.57%     
==========================================
  Files         151      151              
  Lines       15385     9144    -6241     
  Branches     2687     2697      +10     
==========================================
- Hits        14819     8756    -6063     
+ Misses        566      388     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@yasuaki640

Thank you!! Let's go with it.

@yusukebe yusukebe merged commit 18f937d into honojs:main Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants