fix(secure-headers): optimize getPermissionsPolicyDirectives function #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbkn3
force-pushed
the
fix/secureHeader-permissionsPolicy
branch
from
c3343c7
to
6d5ab32
Compare
kbkn3
force-pushed
the
fix/secureHeader-permissionsPolicy
branch
from
6d5ab32
to
8add1b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3398 +/- ##
========================================
Coverage 95.77% 95.77%
========================================
Files 154 154
Lines 9271 9277 +6
Branches 2725 2850 +125
========================================
+ Hits 8879 8885 +6
Misses 392 392 ☔ View full report in Codecov by Sentry. |
kbkn3
force-pushed
the
fix/secureHeader-permissionsPolicy
branch
from
8add1b7
to
0787d00
Compare
yusukebe
changed the title
|
Thanks! No problem. I'll merge it into the |
yusukebe
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codeI am very sorry.
I found a bug (wrong specification) and fixed it.
{delective}: true,truemeans “allowed at all origins” and should be represented as*in the header. However, an empty parenthesis () is printed, implying a restriction.Please let me know if there is a problem, because I don't know if I should direct the PR to the
nextbranch.