Added "Insert" Mode #35
Conversation
Moved the responsibility for trimming a partial match to the autocomplete control. (this and async are prerequisites for web lookup addresses which is coming next)
| datasource = self.autocompleteDataSource; | ||
| } else if([DefaultAutocompleteDataSource respondsToSelector:@selector(textFieldShouldReplaceCompletion:)]) { | ||
| datasource = DefaultAutocompleteDataSource; | ||
| } |
There was a problem hiding this comment.
I'm afraid that this will be a confusing behavior, where essentially the HTAutocompleteTextField can have two data sources. Is there any way that the goal can be accomplished with a single data source?
There was a problem hiding this comment.
It should be noted that having a DefaultAutocompleteDataSource is fairly confusing in and of itself, partially because its unconventional.
|
If I'm reading this correctly, if the data source implements If my understand is correct, could you explain how this would be used? You also mentioned that there would be another pull request coming soon, so perhaps it'll be apparent once all of the pieces are assembled. |
|
The data source does get final word. The reason it works this way is now the Autocomplete control's local variable has the access to the complete autocomplete string and the complete user entered string to determine whether it should be completing. Without that I ended up with quite a bit of hoop jumping to make sure the right address got completed in the right spot (they'd drift as the async calls got a bit ahead of themselves). That said I considered a property on the control which would reduce the amount of code but given it is a datasource concern as it related to the format of the data return by the data source it really does belong there. I did notice that I missed the "optional" line, that ended up in the async commit so I've added it back. |
|
I think my hesitation lies in my believe that the user's acceptance of the autocomplete suggestion should be user-driven. In other words, when the user takes an action that would normally commit or discard the autocomplete suggestion, the text that's on screen should be immediately committed or discarded (regardless of outstanding network requests). Do you agree with this? In fact, this brings to light some potential problems that arise from adding asynchronous autocompletion (#34) suggestions to begin with. |
|
That's exactly how it works. If the suggestion has not yet been presented it isn't committed at all. Unless I'm missing something this should work exactly the way it did previously but allow the datasource to pass the full completion string back to the control rather than pre-trimming it. |
Moved the responsibility for trimming a partial match to the autocomplete control. (this and async are prerequisites for web lookup addresses which is coming next)
Moved the responsibility for trimming a partial
match to the autocomplete control.
(this and async are prerequisites for web lookup
addresses which is coming next)