Fix tests.test_RuLSIF::test_alphadensratio_2d ValueError #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace with 2d array as the compute_density_ratio function argument.
|
Please note that all commits covered by this pull request are also included in #23 Aggregated pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ValueErrorintests.test_RuLSIF::test_alphadensratio_2dby replacing 1d linspace with 2d array as thecompute_density_ratiofunction argument. Code changes basically follow the README multivariate example.Please note the error is raised when
set_compute_kernel_targetis set tonumba(cpuorparalleltargets). Fornumpy(default ifnumbais unavailable) the test passes.Resolves #17 issue.