N21-2072 Prevent reload when navigating to media shelf from sidebar (#…

…3320)
hpi-schul-cloud · Jul 11, 2024 · 6d935f6 · 6d935f6
1 parent 6c1cff0
commit 6d935f6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/modules/ui/layout/sidebar/SidebarItems.composable.ts b/src/modules/ui/layout/sidebar/SidebarItems.composable.ts
@@ -1,13 +1,13 @@
+import { SchulcloudTheme } from "@/serverApi/v3";
 import {
 	ENV_CONFIG_MODULE_KEY,
 	FILE_PATHS_MODULE_KEY,
 	injectStrict,
 } from "@/utils/inject";
-import { SidebarGroupItem, SidebarItems, SidebarSingleItem } from "../types";
-import { SchulcloudTheme } from "@/serverApi/v3";
-import { ComputedRef, computed } from "vue";
 import { mdiBookshelf } from "@mdi/js";
+import { computed, ComputedRef } from "vue";
 import { useI18n } from "vue-i18n";
+import { SidebarGroupItem, SidebarItems, SidebarSingleItem } from "../types";
 
 export const useSidebarItems = () => {
 	const envConfigModule = injectStrict(ENV_CONFIG_MODULE_KEY);
@@ -90,7 +90,7 @@ export const useSidebarItems = () => {
 		},
 		{
 			title: "feature.media-shelf.title",
-			href: "/media-shelf",
+			to: "/media-shelf",
 			icon: mdiBookshelf,
 			feature: "FEATURE_MEDIA_SHELF_ENABLED",
 			testId: "Media-shelf",
@@ -209,7 +209,7 @@ export const useSidebarItems = () => {
 				},
 				{
 					title: "global.sidebar.item.classes",
-					href: "/administration/groups/classes",
+					to: "/administration/groups/classes",
 					testId: "Klassen",
 					permissions: ["ADMIN_VIEW", "TEACHER_LIST"],
 					feature: "FEATURE_SHOW_NEW_CLASS_VIEW_ENABLED",

diff --git a/src/utils/sidebar-base-items.ts b/src/utils/sidebar-base-items.ts
@@ -29,6 +29,9 @@ export type SidebarCategoryItem = SidebarItem & {
 
 export type SidebarItemList = (SidebarItem | SidebarCategoryItem)[];
 
+/**
+ * @deprecated use useSidebarItems composable
+ */
 const getSidebarItems = (): SidebarItemList => [
 	{
 		title: "global.sidebar.item.overview",
@@ -134,7 +137,7 @@ const getSidebarItems = (): SidebarItemList => [
 	},
 	{
 		title: "feature.media-shelf.title",
-		href: "/media-shelf",
+		to: "/media-shelf",
 		icon: mdiBookshelf,
 		testId: "Media-shelf",
 		activeForUrls: ["^/media-shelf($|/.*)"],
@@ -175,7 +178,7 @@ const getSidebarItems = (): SidebarItemList => [
 			{
 				title: "global.sidebar.item.classes",
 				icon: "$class",
-				href: "/administration/groups/classes",
+				to: "/administration/groups/classes",
 				testId: "Klassen",
 				activeForUrls: ["^/administration/groups/classes($|/.*)"],
 				feature: "FEATURE_SHOW_NEW_CLASS_VIEW_ENABLED",
@@ -223,7 +226,7 @@ const getSidebarItems = (): SidebarItemList => [
 			{
 				title: "global.sidebar.item.classes",
 				icon: "$class",
-				href: "/administration/groups/classes",
+				to: "/administration/groups/classes",
 				testId: "Klassen",
 				activeForUrls: ["^/administration/groups/classes($|/.*)"],
 				feature: "FEATURE_SHOW_NEW_CLASS_VIEW_ENABLED",