BC-7415 - Make sidebar usable on tablets #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -16,7 +16,7 @@ | |||
| </v-list-item> | |||
| </template> | |||
| <template v-for="child in item.children" :key="child.title"> | |||
| <SidebarItem :item="child" /> | |||
| <SidebarItem :item="child" :draggable="false" /> | |||
There was a problem hiding this comment.
Where does this draggable prop come from?
There was a problem hiding this comment.
vuedraggable uses that option to not make a component draggable
There was a problem hiding this comment.
I'm very curious about this, as the Sidebar doesn't use vuedraggable
src/layouts/newLoggedIn.layout.vue
Outdated
| const sidebarExpanded = ref(isDesktop.value); | ||
|
|
||
| const onToggleSidebar = () => { | ||
| sidebarExpanded.value = !sidebarExpanded.value; | ||
| }; | ||
| </script> | ||
| <style lang="scss" scoped> | ||
| .fixed-position { |
There was a problem hiding this comment.
I'd rather use !isDesktop and vuetify's utility classes here position-fixed w-100, but it's fine :D
There was a problem hiding this comment.
uhh thats a good point, thx, will adjust :)
|
odalys-dataport
approved these changes
Jun 18, 2024
| @@ -16,7 +16,7 @@ | |||
| </v-list-item> | |||
| </template> | |||
| <template v-for="child in item.children" :key="child.title"> | |||
| <SidebarItem :item="child" /> | |||
| <SidebarItem :item="child" :draggable="false" /> | |||
There was a problem hiding this comment.
I'm very curious about this, as the Sidebar doesn't use vuedraggable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
BC-7415
hpi-schul-cloud/schulcloud-client#3457
Changes
(see Description)
Checklist before merging