BC-7520 - a11y messages

src/composables/ariaLiveNotifier.ts

@@ -1,28 +1,94 @@
+import { computed, ref } from "vue";
+import { useDebounceFn } from "@vueuse/core";
+
+type Importance = "polite" | "assertive";
+let mode: "write" | "queue" = "write";
+const notifications = ref({
+	polite: <string[]>[],
+	assertive: <string[]>[],
+});
+let handle: NodeJS.Timeout | null = null;
+
 export const useAriaLiveNotifier = () => {
+	const numberOfNotifications = computed(
+		() =>
+			notifications.value["polite"].length +
+			notifications.value["assertive"].length
+	);
+
 	const notifyOnScreenReader = (
 		message: string,
-		importance: "off" | "polite" | "assertive" = "polite"
+		importance: Importance = "polite"
 	) => {
-		// should be a div with aria-live="polite | assertive" attribute
-		// and should be appended to the upper level of the DOM tree
-		// the aria-live attribute should be set polite or assertive based on the importance of the message
-		const element = document.getElementById(
-			importance === "polite"
-				? "notify-screen-reader-polite"
-				: "notify-screen-reader-assertive"
-		);
+		notifications.value[importance].push(message);
+		handleNotificationWriting();
+	};
 
-		if (!element) {
-			console.error(
-				`Element with id 'notify-screen-reader-${importance}' not found`
-			);
-			return;
+	const ensurePoliteNotifications = () => {
+		mode = "queue";
+		processNotificationsDebounced();
+	};
+
+	const processNotificationsDebounced = useDebounceFn(
+		() => {
+			mode = "write";
+			handleNotificationWriting(); // explicit call needed for test
+		},
+		1500,
+		{ maxWait: 30000 }
+	);
+
+	const handleNotificationWriting = () => {
+		if (numberOfNotifications.value > 0) {
+			if (mode === "write") {
+				stopPeriodicRetry();
+				writeAllNotifications();
+				return;
+			} else {
+				startPeriodicRetry();
+			}
+		}
+	};
+
+	const startPeriodicRetry = () => {
+		if (handle === null) {
+			handle = setInterval(handleNotificationWriting, 1000);
 		}
+	};
+
+	const stopPeriodicRetry = () => {
+		if (handle) {
+			clearInterval(handle);
+			handle = null;
+		}
+	};
+
+	const writeAllNotifications = () => {
+		writeNotifications("polite");
+		writeNotifications("assertive");
+	};
+
+	const writeNotifications = (importance: Importance) => {
+		const element = getElement(importance);
+
+		if (element && notifications.value[importance].length > 0) {
+			element.innerHTML = notifications.value[importance]
+				.map((m) => `<span>${m}</span>`)
+				.join("");
+			notifications.value[importance] = [];
+		}
+	};
+
+	const getElement = (importance: Importance): HTMLElement | null => {
+		const element = document.getElementById(
+			`notify-screen-reader-${importance}`
+		);
 
-		element.innerHTML += `<span>${message}</span>`;
+		return element;
 	};
 
 	return {
 		notifyOnScreenReader,
+		ensurePoliteNotifications,
 	};
 };

src/composables/ariaLiveNotifier.unit.ts

@@ -7,9 +7,11 @@ describe("useAriaLiveNotifier", () => {
 					<div id="notify-screen-reader-polite"></div>
 					<div id="notify-screen-reader-assertive"></div>
 				</div>`;
+
+		jest.useFakeTimers();
 	});
+
 	it("should notify on screen reader on 'aria-live=assertive' mode", () => {
-		jest.useFakeTimers();
 		const { notifyOnScreenReader } = useAriaLiveNotifier();
 		const element = document.getElementById("notify-screen-reader-assertive");
 		const message = "Assertive screen reader message";
@@ -20,7 +22,6 @@ describe("useAriaLiveNotifier", () => {
 	});
 
 	it("should notify on screen reader on 'aria-live=polite' mode", () => {
-		jest.useFakeTimers();
 		const { notifyOnScreenReader } = useAriaLiveNotifier();
 		const element = document.getElementById("notify-screen-reader-polite");
 		const message = "Polite screen reader message";
@@ -29,4 +30,28 @@ describe("useAriaLiveNotifier", () => {
 		jest.advanceTimersByTime(3000);
 		expect(element?.innerHTML).toBe(`<span>${message}</span>`);
 	});
+
+	describe("ensurePoliteNotifications", () => {
+		describe("when politeNotifications are ensured", () => {
+			it("should notify all collected messages after some time without user interaction", () => {
+				const { notifyOnScreenReader, ensurePoliteNotifications } =
+					useAriaLiveNotifier();
+				const element = document.getElementById("notify-screen-reader-polite");
+				const message1 = "Polite screen reader message 1";
+				const message2 = "Polite screen reader message 2";
+
+				ensurePoliteNotifications();
+				notifyOnScreenReader(message1, "polite");
+				notifyOnScreenReader(message2, "polite");
+
+				expect(element?.innerHTML).toBe("");
+
+				jest.advanceTimersByTime(3000);
+
+				expect(element?.innerHTML).toBe(
+					`<span>${message1}</span><span>${message2}</span>`
+				);
+			});
+		});
+	});
 });

src/modules/data/board/boardActions/boardSocketApi.composable.ts

@@ -74,7 +74,7 @@ export const useBoardSocketApi = () => {
 			),
 		];
 
-		const ariaLiveNotification = [
+		const ariaLiveNotifications = [
 			on(BoardActions.createCardSuccess, notifyCreateCardSuccess),
 			on(CardActions.deleteCardSuccess, notifyDeleteCardSuccess),
 			on(BoardActions.createColumnSuccess, notifyCreateColumnSuccess),
@@ -93,7 +93,7 @@ export const useBoardSocketApi = () => {
 			action,
 			...successActions,
 			...failureActions,
-			...ariaLiveNotification,
+			...ariaLiveNotifications,
 			on(BoardActions.disconnectSocket, disconnectSocketRequest)
 		);
 	};

src/modules/feature/board-text-element/RichTextContentElement.vue

@@ -10,9 +10,10 @@
 			class="rich_text"
 			:autofocus="autofocus"
 			:value="modelValue.text"
-			@update:value="($event) => (modelValue.text = $event)"
+			@update:value="onUpdateElement"
 			@delete:element="onDeleteElement"
-			@blur="() => (autofocus = false)"
+			@blur="onBlur"
+			@keyup.capture="onKeyUp"
 		/>
 	</div>
 </template>
@@ -23,6 +24,7 @@ import { useBoardFocusHandler, useContentElementState } from "@data-board";
 import { defineComponent, PropType, ref, toRef } from "vue";
 import RichTextContentElementDisplay from "./RichTextContentElementDisplay.vue";
 import RichTextContentElementEdit from "./RichTextContentElementEdit.vue";
+import { useAriaLiveNotifier } from "@/composables/ariaLiveNotifier";
 
 export default defineComponent({
 	name: "RichTextContentElement",
@@ -40,6 +42,8 @@ export default defineComponent({
 	emits: ["delete:element"],
 	setup(props, { emit }) {
 		const { modelValue } = useContentElementState(props);
+		const { ensurePoliteNotifications } = useAriaLiveNotifier();
+
 		const autofocus = ref(false);
 		const element = toRef(props, "element");
 		useBoardFocusHandler(element.value.id, ref(null), () => {
@@ -50,10 +54,23 @@ export default defineComponent({
 			emit("delete:element", element.value.id);
 		};
 
+		const onUpdateElement = (text: string) => {
+			modelValue.value.text = text;
+		};
+
+		const onBlur = () => {
+			autofocus.value = false;
+		};
+
+		const onKeyUp = () => ensurePoliteNotifications();
+
 		return {
+			autofocus,
 			modelValue,
+			onBlur,
 			onDeleteElement,
-			autofocus,
+			onKeyUp,
+			onUpdateElement,
 		};
 	},
 });

src/modules/feature/board/card/CardTitle.vue

@@ -29,7 +29,7 @@ export default defineComponent({
 	props: {
 		value: {
 			type: String,
-			required: true,
+			default: "",
 		},
 		isEditMode: {
 			type: Boolean,

src/modules/feature/editor/CKEditor.vue

@@ -37,7 +37,14 @@ export default defineComponent({
 	components: {
 		ckeditor: CKEditor.component,
 	},
-	emits: ["ready", "focus", "update:value", "blur", "keyboard:delete"],
+	emits: [
+		"ready",
+		"focus",
+		"update:value",
+		"blur",
+		"keyboard",
+		"keyboard:delete",
+	],
 	props: {
 		value: {
 			type: String,