Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-2019 show media shelf tool usages #3298

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Jun 21, 2024

Short Description

when school admin deletes a school external tool, the tool usages from media shelf are also shown

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

/>
<RenderHTML
data-testid="delete-dialog-content-board-elements"
:class="isMediaBoardUsageVisible ? 'text-md mb-0' : 'text-md'"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

src/components/administration/ExternalToolSection.vue Outdated Show resolved Hide resolved
src/components/administration/ExternalToolSection.vue Outdated Show resolved Hide resolved
@@ -243,8 +243,16 @@ export default {
'Die schulspezifischen Parameter für das externe Tool werden hier konfiguriert. Nach dem Speichern der Konfiguration ist das Tool innerhalb der Schule verfügbar.<br><br>\nWeitere Informationen sind in unserem <a href="https://docs.dbildungscloud.de/x/uoKqDg" target="_blank">Hilfebereich zu externen Tools</a> zu finden.',
"components.administration.externalToolsSection.dialog.content.metadata.error":
"Die Verwendung des Tools konnte nicht ermittelt werden.",
"components.administration.externalToolsSection.dialog.content":
"Sind Sie sich sicher, dass Sie das Tool <b>{itemName}</b> löschen wollen? </br></br>Zurzeit wird das Tool wie folgt genutzt: <br><b>{courseCount}</b> Kurs(e) <br><b>{boardElementCount}</b> Spalten-Board(s) <br><br> Achtung: Wenn das Tool entfernt wird, kann es für diese Schule nicht mehr genutzt werden.",
"components.administration.externalToolsSection.dialog.content.header":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

arnegns
arnegns previously approved these changes Jun 27, 2024
Copy link

sonarcloud bot commented Jul 5, 2024

@GordonNicholasCap GordonNicholasCap merged commit 1063316 into main Jul 5, 2024
47 of 48 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-2019-show-tool-usage branch July 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants