Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7588 - fix card title spacing #3310

Merged
merged 12 commits into from
Jul 2, 2024
Merged

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Jul 1, 2024

Short Description

During to some changes to fix problems from the migration to Vue3 - a wrong spacing over card titles was introduced and gets fixed with this PR.

Links to Ticket and related Pull-Requests

BC-7588

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@muratmerdoglu-dp muratmerdoglu-dp merged commit 319820e into main Jul 2, 2024
46 of 48 checks passed
@muratmerdoglu-dp muratmerdoglu-dp deleted the BC-7588-fix-card-title-spacing branch July 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants