Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7624 - Skip links broken #3317

Merged
merged 19 commits into from
Jul 16, 2024
Merged

BC-7624 - Skip links broken #3317

merged 19 commits into from
Jul 16, 2024

Conversation

wolfganggreschus
Copy link
Contributor

@wolfganggreschus wolfganggreschus commented Jul 5, 2024

Short Description

When initially entering a page and pressing tab a "skip link" appears. Tipping enter should navigate the cursor to main content.

Links to Ticket and related Pull-Requests

BC-7624

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@wolfganggreschus wolfganggreschus self-assigned this Jul 5, 2024
@wolfganggreschus wolfganggreschus marked this pull request as draft July 5, 2024 12:23
@odalys-dataport odalys-dataport marked this pull request as ready for review July 10, 2024 12:21
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.vue Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.unit.ts Outdated Show resolved Hide resolved
src/components/molecules/SkipLinks.vue Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 16, 2024

@wolfganggreschus wolfganggreschus merged commit 8ca6325 into main Jul 16, 2024
48 of 49 checks passed
@wolfganggreschus wolfganggreschus deleted the BC-7624-skip-links-broken branch July 16, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants