Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2070 Prevent media shelf card from duplicating #3329

Merged
merged 6 commits into from
Jul 19, 2024
Merged

N21-2070 Prevent media shelf card from duplicating #3329

merged 6 commits into from
Jul 19, 2024

Conversation

GordonNicholasCap
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap commented Jul 17, 2024 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@GordonNicholasCap GordonNicholasCap changed the title Prevent media shelf card from duplicating after other cards are moved N21-2070 Prevent media shelf card from duplicating after other cards are moved Jul 18, 2024
@GordonNicholasCap GordonNicholasCap changed the title N21-2070 Prevent media shelf card from duplicating after other cards are moved N21-2070 Prevent media shelf card from duplicating Jul 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GordonNicholasCap GordonNicholasCap merged commit 3ae56e2 into main Jul 19, 2024
47 of 48 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-2070-bugfix-mediashelf-duplicates branch July 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrikallab mrikallab mrikallab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonNicholasCap @mrikallab