Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-3289 API_URL -> PUBLIC_BACKEND_URL #3388

Merged
merged 1 commit into from
Sep 2, 2024
Merged

BC-3289 API_URL -> PUBLIC_BACKEND_URL #3388

merged 1 commit into from
Sep 2, 2024

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Sep 2, 2024 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-3289
hpi-schul-cloud/dof_app_deploy#958

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@Loki-Afro Loki-Afro mentioned this pull request Sep 2, 2024
Merged
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Loki-Afro Loki-Afro merged commit 0533277 into main Sep 2, 2024
71 of 75 checks passed
@Loki-Afro Loki-Afro deleted the bc-3289 branch September 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loki-Afro @MartinSchuhmacher