Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5178 - Improve icon references #3391

Merged
merged 22 commits into from
Sep 6, 2024
Merged

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Sep 3, 2024

Short Description

Provide a clearly defined set of icons under the path "@icons/material".
The import of icons from that path is enforced by a custom linter rule.

Links to Ticket and related Pull-Requests

BC-5178

Changes

  • add custom linter rule for material icon imports
  • add local plugin for eslint: eslint-plugin-schulcloud in lib directory
  • remove prefix "mdiCustom" for custom icons
  • import icons instead of using string aliases for material icons (replace "$mdi...")

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@NFriedo NFriedo marked this pull request as ready for review September 5, 2024 08:33
Copy link

sonarcloud bot commented Sep 6, 2024

@NFriedo NFriedo merged commit 5ab53c3 into main Sep 6, 2024
71 checks passed
@NFriedo NFriedo deleted the BC-5178-improve-icon-references branch September 6, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants